From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 8/9] gdb: remove VALUE_REGNUM, add value::regnum
Date: Fri, 22 Dec 2023 11:57:39 -0500 [thread overview]
Message-ID: <9a98a8c9-fa47-412d-89f6-1abee23db1a2@efficios.com> (raw)
In-Reply-To: <87bkai18od.fsf@tromey.com>
On 2023-12-22 11:52, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> +/* See value.h. */
> Simon> +
> Simon> +int
> Simon> +value::regnum ()
> Simon> {
> Simon> gdb_assert (m_lval == lval_register);
> Simon> - return &m_location.reg.regnum;
> Simon> +
> Simon> + return m_location.reg.regnum;
>
> I wonder if this could just be inlined in the header.
>
> Tom
Yes, I think it's a good candidate to be in the header, I'll do that.
Simon
next prev parent reply other threads:[~2023-12-22 16:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 19:16 [PATCH 0/9] Some register value cleanups Simon Marchi
2023-12-21 19:16 ` [PATCH 1/9] gdb: don't set frame id after calling cooked_read_value Simon Marchi
2023-12-21 19:16 ` [PATCH 2/9] gdb: pass frame_info_ptr to gdbarch_value_from_register Simon Marchi
2023-12-22 16:40 ` Tom Tromey
2023-12-22 16:53 ` Simon Marchi
2023-12-22 16:56 ` Tom Tromey
2023-12-21 19:16 ` [PATCH 3/9] gdb: pass non-nullptr frame to gdbarch_value_from_register in address_from_register Simon Marchi
2023-12-21 19:16 ` [PATCH 4/9] gdb: add type parameter to value::allocate_register and add value::allocate_register_lazy Simon Marchi
2023-12-21 19:16 ` [PATCH 5/9] gdb: remove read_frame_register_value's frame parameter Simon Marchi
2023-12-21 19:16 ` [PATCH 6/9] gdb: implement address_from_register using value_from_register Simon Marchi
2023-12-21 19:16 ` [PATCH 7/9] gdb: remove VALUE_NEXT_FRAME_ID, add value::next_frame_id Simon Marchi
2023-12-22 16:51 ` Tom Tromey
2023-12-22 16:56 ` Simon Marchi
2023-12-22 17:02 ` Tom Tromey
2023-12-22 17:06 ` Simon Marchi
2023-12-24 15:35 ` Simon Marchi
2023-12-21 19:16 ` [PATCH 8/9] gdb: remove VALUE_REGNUM, add value::regnum Simon Marchi
2023-12-22 16:52 ` Tom Tromey
2023-12-22 16:57 ` Simon Marchi [this message]
2023-12-21 19:16 ` [PATCH 9/9] gdb: make value::allocate_register_lazy store id of next non-inline frame Simon Marchi
2023-12-22 16:53 ` [PATCH 0/9] Some register value cleanups Tom Tromey
2023-12-22 16:58 ` Simon Marchi
2023-12-22 17:02 ` Tom Tromey
2023-12-24 18:28 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a98a8c9-fa47-412d-89f6-1abee23db1a2@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).