From: Tom Tromey <tromey@adacore.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Make 'import gdb.events' work
Date: Mon, 18 Jul 2022 11:28:59 -0600 [thread overview]
Message-ID: <8735eyl484.fsf@tromey.com> (raw)
In-Reply-To: <20220715133317.1bd0103b@f35-zws-1> (Kevin Buettner's message of "Fri, 15 Jul 2022 13:33:17 -0700")
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
>> + /* Define all internal modules. These are all imported (and thus
>> + created) during initialization. */
>> + struct _inittab mods[3] =
>> + {
>> + { "_gdb", init__gdb_module },
>> + { "_gdbevents", gdbpy_events_mod_func },
>> + { nullptr, nullptr }
>> + };
Kevin> Something I just noticed while looking at a conflict while rebasing
Kevin> my Python 3.11 deprecation patch:
Kevin> Is there any reason not to do...
Kevin> struct _inittab mods[] =
Kevin> ...
Kevin> instead?
Not that I can think of, and I don't recall writing it this way :)
It seems better to remove the '3' TBH.
Tom
prev parent reply other threads:[~2022-07-18 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 13:20 Tom Tromey
2022-07-05 16:35 ` Tom Tromey
2022-07-15 20:33 ` Kevin Buettner
2022-07-18 17:28 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735eyl484.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).