* [PATCH] Fix Ada exception regression on Windows
@ 2022-05-09 16:02 Tom Tromey
2022-05-16 15:01 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2022-05-09 16:02 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
The breakpoint c++-ification series introduced another bug in Ada --
it caused "catch exception" and related commands to fail on Windows.
The problem is that the re_set method calls the wrong superclass
method, so the breakpoint doesn't get correctly re-set when the
runtime offsets change. This patch fixes the problem.
---
gdb/ada-lang.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 8333671c48b..248b847cfbc 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -12212,7 +12212,7 @@ ada_catchpoint::re_set ()
{
/* Call the base class's method. This updates the catchpoint's
locations. */
- this->breakpoint::re_set ();
+ this->base_breakpoint::re_set ();
/* Reparse the exception conditional expressions. One for each
location. */
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix Ada exception regression on Windows
2022-05-09 16:02 [PATCH] Fix Ada exception regression on Windows Tom Tromey
@ 2022-05-16 15:01 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2022-05-16 15:01 UTC (permalink / raw)
To: Tom Tromey via Gdb-patches; +Cc: Tom Tromey
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> The breakpoint c++-ification series introduced another bug in Ada --
Tom> it caused "catch exception" and related commands to fail on Windows.
Tom> The problem is that the re_set method calls the wrong superclass
Tom> method, so the breakpoint doesn't get correctly re-set when the
Tom> runtime offsets change. This patch fixes the problem.
I'm checking this in.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-16 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-09 16:02 [PATCH] Fix Ada exception regression on Windows Tom Tromey
2022-05-16 15:01 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).