public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Aaron Merey <amerey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/dwarf2: Check for missing abbrev
Date: Thu, 14 Mar 2024 06:36:06 -0600	[thread overview]
Message-ID: <874jd9m1mx.fsf@tromey.com> (raw)
In-Reply-To: <20240313201827.1853989-1-amerey@redhat.com> (Aaron Merey's message of "Wed, 13 Mar 2024 16:18:27 -0400")

> A corrupt debuginfo file can result in a null abbrev_info pointer
> being passed to cooked_indexer::scan_attributes.  There is no check
> for whether the abbrev pointer is null and SIGSEGV occurs when
> attempting to dereference the pointer.

Also, I was wondering if this case can be tested somehow.  Perhaps the
DWARF assembler could be modified to allow the creation of corrupted
debug info.  It seems to me if we're going forward with the security
policy, then we're going to need to test these things.

Tom

      parent reply	other threads:[~2024-03-14 12:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 20:18 Aaron Merey
2024-03-14  1:39 ` Simon Marchi
2024-03-14 12:31   ` Tom Tromey
2024-03-14 13:56     ` Simon Marchi
2024-03-14 14:31       ` Tom Tromey
2024-03-14 17:45         ` Aaron Merey
2024-03-14 17:52           ` Simon Marchi
2024-03-14 12:29 ` Tom Tromey
2024-03-14 12:36 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jd9m1mx.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=amerey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).