From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>, Aaron Merey <amerey@redhat.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/dwarf2: Check for missing abbrev
Date: Thu, 14 Mar 2024 08:31:55 -0600 [thread overview]
Message-ID: <87r0gclw9w.fsf@tromey.com> (raw)
In-Reply-To: <22883d8d-b634-4e71-802c-239114d01279@simark.ca> (Simon Marchi's message of "Thu, 14 Mar 2024 09:56:18 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> The issue is corrupt DWARF -- the DIE specifies an abbrev that doesn't exist.
Simon> If it was an abbrev number that didn't exist, then peek_die_abbrev would
Simon> throw here:
Yeah sorry about that.
Simon> If peek_die_abbrev returns nullptr, it's because it read abbrev number 0
Simon> specifically (which normally means "end of DIE list", but is unexpected
Simon> at this particular place). So I'm just wondering what "kind" of
Simon> corruption causes it to be 0. The concrete case I'm worried about is
Simon> the possibility that the file is truncated and we go read an offset that
Simon> is out of our buffer's bounds. In that case, some bounds checking
Simon> should probably be added somehwere.
Yes, this definitely needs to be done at some point.
Tom
next prev parent reply other threads:[~2024-03-14 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 20:18 Aaron Merey
2024-03-14 1:39 ` Simon Marchi
2024-03-14 12:31 ` Tom Tromey
2024-03-14 13:56 ` Simon Marchi
2024-03-14 14:31 ` Tom Tromey [this message]
2024-03-14 17:45 ` Aaron Merey
2024-03-14 17:52 ` Simon Marchi
2024-03-14 12:29 ` Tom Tromey
2024-03-14 12:36 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0gclw9w.fsf@tromey.com \
--to=tom@tromey.com \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).