Re: [PATCH 1/5] Introduce new overload of read_text_file_to_string

[Tom Tromey <tromey@adacore.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> On 2/16/24 19:37, Tom Tromey wrote:
>> +/* Read the entire content of FILE into an std::string.  */
>> +
>> +extern std::string read_text_file_to_string (FILE *file);
>> +
>> #endif /* COMMON_FILESTUFF_H */
>> 
Tom> It occurred to me that if this reads the entire content of FILE,
Tom> shouldn't it start with an "fseek (file, 0, SEEK_SET)"?

Tom> We could add an argument at_start that lets us skip the fseek, and
Tom> default it to false, and call it with at_start set to true from the
Tom> "const char *path" version of read_text_file_to_string.

I'd rather not add things that we don't need.
How about I rename the function instead?

Tom