Re: [PATCH] [gdb/build] Fix adding -DNDEBUG to python flags of release build

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> [ This was not obvious to me, but apparently evaluating an empty or undefined
Tom> variable in this context is similar to using ':' or 'true', so the line is
Tom> evaluated as:

TIL.

Tom> [ Unfortunately, the move might introduce issues similar to the one we're
Tom> fixing, and I'm not sure how to check for this.  Shellcheck doesn't detect
Tom> this type of problem.  FWIW, I did run shellcheck (using arguments -xa, in the
Tom> src/gdb directory to make sure ../bfd/development.sh is taken into account)
Tom> before and after and observed that the number of lines/words/chars in the
Tom> shellcheck output is identical. ]

I don't think there's a good way to figure this out.  It's one of the
problems with autoconf.

If we do discover an issue, we may have to split the macro in two; or
perhaps move more code into it.

Anyway I think this is ok.
Approved-By: Tom Tromey <tom@tromey.com>


Tom