From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Fix DAP stackTrace through frames without debuginfo
Date: Mon, 06 Mar 2023 08:17:10 -0700 [thread overview]
Message-ID: <874jqx7vux.fsf@tromey.com> (raw)
In-Reply-To: <20230215194847.3805619-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 15 Feb 2023 12:48:47 -0700")
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> The DAP stackTrace implementation did not fully account for frames
Tom> without debuginfo. Attemping this would yield a result like:
Tom> {"request_seq": 5, "type": "response", "command": "stackTrace", "success": false, "message": "'NoneType' object has no attribute 'filename'", "seq": 11}
Tom> This patch fixes the problem by adding another check for None.
I'm checking this in now.
Tom
next prev parent reply other threads:[~2023-03-06 15:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 19:48 Tom Tromey
2023-03-06 15:17 ` Tom Tromey [this message]
2023-03-09 8:38 ` Tom de Vries
2023-03-09 14:24 ` Tom Tromey
2023-03-09 14:52 ` Tom Tromey
2023-03-09 16:10 ` Tom de Vries
2023-03-09 18:45 ` Tom Tromey
2023-03-09 20:35 ` Tom de Vries
2023-03-13 18:46 ` Tom Tromey
2023-03-14 13:08 ` Tom Tromey
2023-03-14 13:28 ` Tom de Vries
2023-03-14 14:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jqx7vux.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).