From: Andrew Burgess <aburgess@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Add support for readline 8.2
Date: Mon, 21 Mar 2022 11:09:13 +0000 [thread overview]
Message-ID: <874k3rtvdy.fsf@redhat.com> (raw)
In-Reply-To: <87ils8ojkd.fsf@igel.home>
Andreas Schwab <schwab@linux-m68k.org> writes:
> In readline 8.2 the type of rl_completer_word_break_characters changed to
> include const.
LGTM.
Thanks,
Andrew
> ---
> gdb/completer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/completer.c b/gdb/completer.c
> index d3900ae2014..a51c16ac7f8 100644
> --- a/gdb/completer.c
> +++ b/gdb/completer.c
> @@ -36,7 +36,7 @@
> calling a hook instead so we eliminate the CLI dependency. */
> #include "gdbcmd.h"
>
> -/* Needed for rl_completer_word_break_characters() and for
> +/* Needed for rl_completer_word_break_characters and for
> rl_filename_completion_function. */
> #include "readline/readline.h"
>
> @@ -2011,7 +2011,7 @@ gdb_completion_word_break_characters_throw ()
> rl_basic_quote_characters = NULL;
> }
>
> - return rl_completer_word_break_characters;
> + return (char *) rl_completer_word_break_characters;
> }
>
> char *
> --
> 2.35.0
>
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
prev parent reply other threads:[~2022-03-21 11:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 13:11 Andreas Schwab
2022-03-21 11:09 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874k3rtvdy.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).