From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCHv2] gdb: improve error reporting for 'save gdb-index'
Date: Fri, 08 Dec 2023 09:26:23 -0700 [thread overview]
Message-ID: <875y18hd8w.fsf@tromey.com> (raw)
In-Reply-To: <77f7dfc0615d0734db1a1bca2691170f6f7e5cfe.1702051454.git.aburgess@redhat.com> (Andrew Burgess's message of "Fri, 8 Dec 2023 16:06:55 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> --- a/gdb/testsuite/lib/gdb.exp
Andrew> +++ b/gdb/testsuite/lib/gdb.exp
Andrew> +proc get_index_type { objfile { testname "" } } {
Andrew> + if { $testname eq "" } {
Andrew> + set testname "find index type"
Andrew> + }
...
This seems to overlap with proc have_index.
I wonder if they can be combined.
Tom
next prev parent reply other threads:[~2023-12-08 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 19:29 [PATCH] " Andrew Burgess
2023-12-05 8:25 ` Tom de Vries
2023-12-08 16:06 ` [PATCHv2] " Andrew Burgess
2023-12-08 16:26 ` Tom Tromey [this message]
2023-12-12 14:56 ` [PATCHv3] " Andrew Burgess
2023-12-12 20:21 ` Tom Tromey
2023-12-13 8:56 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y18hd8w.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).