From: Tom Tromey <tom@tromey.com>
To: Simon Farre via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Farre <simon.farre.cx@gmail.com>
Subject: Re: [PATCH v2] gdb/dap - Getting thread names
Date: Wed, 14 Jun 2023 09:05:35 -0600 [thread overview]
Message-ID: <875y7q5bk0.fsf@tromey.com> (raw)
In-Reply-To: <20230614133518.46605-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Wed, 14 Jun 2023 15:35:18 +0200")
>>>>> Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:
> So I couldn't determine right now, what operation of name change that
> GDB does not pick up, but with this patch, GDB will pick up the thread
> names for an applications that set the name of a thread in ways that
> aren't obvious.
I think gdb just reads the thread names on demand. So, on Linux, it
doesn't really notice when they change. (On Windows there's a different
mechanism and thread names can sometimes be seen by the debugger via an
SEH handler.)
Maybe gdb could use inotify on the comm files but it's probably not
really worthwhile. For DAP, I don't think there's really a way to
notify the client of thread name changes anyway.
Anyway, this patch is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2023-06-14 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 13:35 Simon Farre
2023-06-14 15:05 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y7q5bk0.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.farre.cx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).