From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Rewrite gdb_mpz::operator==
Date: Fri, 21 Apr 2023 07:00:51 -0600 [thread overview]
Message-ID: <875y9p2xvg.fsf@tromey.com> (raw)
In-Reply-To: <119e1750-83c2-9e9f-a60a-3c14b2d6c09a@simark.ca> (Simon Marchi's message of "Wed, 19 Apr 2023 12:23:18 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> It's a bit hard to understand what the intent is, if you don't know the
Simon> problematic already. Could you add a comment explaining that?
Sure.
Simon> Also, wouldn't it work to compare size? Like:
Simon> if (sizeof (T) <= sizeof (long))
Yeah, though I was concerned that the compiler might emit warnings about
always-true conditions in this case.
Tom
next prev parent reply other threads:[~2023-04-21 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 15:09 Tom Tromey
2023-04-19 16:23 ` Simon Marchi
2023-04-21 13:00 ` Tom Tromey [this message]
2023-04-21 13:13 ` Simon Marchi
2023-04-21 15:02 ` Tom Tromey
2023-04-24 16:31 ` Tom Tromey
2023-04-25 18:55 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y9p2xvg.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).