From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>,
Simon Marchi <simon.marchi@efficios.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH v2] gdb/dwarf: dump cooked index contents in cooked_index_functions::dump
Date: Tue, 31 Jan 2023 10:27:37 -0700 [thread overview]
Message-ID: <875ycmmx6e.fsf@tromey.com> (raw)
In-Reply-To: <92a28fac-9d20-f0be-fd7e-b9ad8683c615@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 31 Jan 2023 10:49:10 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>> I think this would be a good improvement. Especially the "No debugging
>> symbols found..." message now being printed, is, I think, a good thing.
Simon> Although I agree with you, given Tom's answer, I will go with the simple
Simon> nullptr check. Hopefully we can being back the "No debugging symbols
Simon> found" message at some later point.
There really is debuginfo -- it's just not usable. So I think it would
be better to print a big red error saying that, because it's probably of
interest to the user.
Maybe "info shared" could also be augmented to share this sort of info.
Tom
next prev parent reply other threads:[~2023-01-31 17:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 16:03 Simon Marchi
2023-01-30 16:08 ` Simon Marchi
2023-01-30 19:07 ` Tom Tromey
2023-01-30 20:08 ` Simon Marchi
2023-01-30 21:35 ` Andrew Burgess
2023-01-31 3:06 ` Simon Marchi
2023-01-31 9:21 ` Andrew Burgess
2023-01-31 15:49 ` Simon Marchi
2023-01-31 17:27 ` Tom Tromey [this message]
2023-01-31 14:19 ` Tom Tromey
2023-01-31 15:35 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ycmmx6e.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).