Re: [PATCH 2/2] gdb/testsuite: new test for recent dwarf reader issue

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Thank you for doing this.
>
> Andrew>   - However, GDB checks each partial symbol using multiple languages,
> Andrew>     not just the current language (C in this case), so, when GDB
> Andrew>     checks using the C++ language, the symbol name is first demangled,
> Andrew>     the code that does this can be found
> Andrew>     lookup_name_info::language_lookup_name.  As the demangled form of
> Andrew>     'signed int' is just 'int', GDB then looks for any symbols with
> Andrew>     the name 'int', most partial symtabs will contain such a symbol,
> Andrew>     so GDB ends up expanding pretty much every symtab.
>
> It's a pedantic point but what happens here is name canonicalization,
> not demangling.  Demangling is just used to refer to the translation
> from a name like "_Zmumble" to "something::else" -- that is, the input
> is a linkage name and the output is a C++ name.  Canonicalization takes
> a C++ name as input and returns the standard form, basically dealing
> with the fact that C++ (and as we discovered, C) has multiple possible
> spellings for some symbols.

Please, be pedantic.  My goal here was to better understand this code,
there's no point me understanding it wrong.

I'll reword that paragraph.

Thanks for taking a look.

Andrew