public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>,  Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH 2/2] gdb/testsuite: new test for recent dwarf reader issue
Date: Fri, 09 Dec 2022 11:18:19 -0700	[thread overview]
Message-ID: <87lengh250.fsf@tromey.com> (raw)
In-Reply-To: <c7588e14cbf089e6922b7a254402ffb7ca05fb53.1670513780.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Thu, 8 Dec 2022 15:38:33 +0000")

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Thank you for doing this.

Andrew>   - However, GDB checks each partial symbol using multiple languages,
Andrew>     not just the current language (C in this case), so, when GDB
Andrew>     checks using the C++ language, the symbol name is first demangled,
Andrew>     the code that does this can be found
Andrew>     lookup_name_info::language_lookup_name.  As the demangled form of
Andrew>     'signed int' is just 'int', GDB then looks for any symbols with
Andrew>     the name 'int', most partial symtabs will contain such a symbol,
Andrew>     so GDB ends up expanding pretty much every symtab.

It's a pedantic point but what happens here is name canonicalization,
not demangling.  Demangling is just used to refer to the translation
from a name like "_Zmumble" to "something::else" -- that is, the input
is a linkage name and the output is a C++ name.  Canonicalization takes
a C++ name as input and returns the standard form, basically dealing
with the fact that C++ (and as we discovered, C) has multiple possible
spellings for some symbols.

Tom

  reply	other threads:[~2022-12-09 18:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08 15:38 [PATCH 0/2] New test for slow DWARF " Andrew Burgess
2022-12-08 15:38 ` [PATCH 1/2] gdb/testsuite: fix readnow detection Andrew Burgess
2022-12-08 15:38 ` [PATCH 2/2] gdb/testsuite: new test for recent dwarf reader issue Andrew Burgess
2022-12-09 18:18   ` Tom Tromey [this message]
2022-12-09 19:24     ` Andrew Burgess
2022-12-14 14:47       ` Luis Machado
2022-12-15 11:22         ` Andrew Burgess
2022-12-19 13:20           ` Luis Machado
2022-12-19 13:52             ` Andrew Burgess
2022-12-20  8:43               ` tdevries
2022-12-20 10:32                 ` Andrew Burgess
2022-12-20 13:20                   ` Andrew Burgess
2022-12-20 14:04                     ` Luis Machado
2022-12-20 14:54                     ` tdevries
2022-12-24 16:05                       ` Andrew Burgess
2022-12-09 18:18 ` [PATCH 0/2] New test for slow DWARF " Tom Tromey
2022-12-14 10:25   ` Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lengh250.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).