* [pushed] gdb/testsuite: fix gdb.trace/signal.exp on x86
@ 2022-05-30 16:59 Simon Marchi
2022-05-31 8:24 ` Andrew Burgess
0 siblings, 1 reply; 2+ messages in thread
From: Simon Marchi @ 2022-05-30 16:59 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
From: Simon Marchi <simon.marchi@efficios.com>
Patch
202be274a41a ("opcodes/i386: remove trailing whitespace from insns with zero operands")
causes this regression:
FAIL: gdb.trace/signal.exp: find syscall insn in kill
It's because the test still expects to match a whitespace after the
instruction, which the patch mentioned above removed. Remove the
whitespaces for the regexp.
Change-Id: Ie194273cc942bfd91332d4035f6eec55b7d3a428
---
gdb/testsuite/gdb.trace/signal.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.trace/signal.exp b/gdb/testsuite/gdb.trace/signal.exp
index e5b608974869..782abeb69d38 100644
--- a/gdb/testsuite/gdb.trace/signal.exp
+++ b/gdb/testsuite/gdb.trace/signal.exp
@@ -55,7 +55,7 @@ set syscall_insn ""
# Define the syscall instruction for each target.
if { [istarget "i\[34567\]86-*-linux*"] || [istarget "x86_64-*-linux*"] } {
- set syscall_insn "\[ \t\](int|syscall|sysenter)\[ \t\]"
+ set syscall_insn "\[ \t\](int|syscall|sysenter)"
} elseif { [istarget "aarch64*-*-linux*"] || [istarget "arm*-*-linux*"] } {
set syscall_insn "\[ \t\](swi|svc)\[ \t\]"
} else {
base-commit: 5541bfdc97936581c0ead915e9117e22f21bdb12
--
2.36.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pushed] gdb/testsuite: fix gdb.trace/signal.exp on x86
2022-05-30 16:59 [pushed] gdb/testsuite: fix gdb.trace/signal.exp on x86 Simon Marchi
@ 2022-05-31 8:24 ` Andrew Burgess
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Burgess @ 2022-05-31 8:24 UTC (permalink / raw)
To: Simon Marchi, gdb-patches; +Cc: Simon Marchi
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> From: Simon Marchi <simon.marchi@efficios.com>
>
> Patch
>
> 202be274a41a ("opcodes/i386: remove trailing whitespace from insns with zero operands")
>
> causes this regression:
>
> FAIL: gdb.trace/signal.exp: find syscall insn in kill
>
> It's because the test still expects to match a whitespace after the
> instruction, which the patch mentioned above removed. Remove the
> whitespaces for the regexp.
Thanks for fixing this.
Andrew
>
> Change-Id: Ie194273cc942bfd91332d4035f6eec55b7d3a428
> ---
> gdb/testsuite/gdb.trace/signal.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.trace/signal.exp b/gdb/testsuite/gdb.trace/signal.exp
> index e5b608974869..782abeb69d38 100644
> --- a/gdb/testsuite/gdb.trace/signal.exp
> +++ b/gdb/testsuite/gdb.trace/signal.exp
> @@ -55,7 +55,7 @@ set syscall_insn ""
> # Define the syscall instruction for each target.
>
> if { [istarget "i\[34567\]86-*-linux*"] || [istarget "x86_64-*-linux*"] } {
> - set syscall_insn "\[ \t\](int|syscall|sysenter)\[ \t\]"
> + set syscall_insn "\[ \t\](int|syscall|sysenter)"
> } elseif { [istarget "aarch64*-*-linux*"] || [istarget "arm*-*-linux*"] } {
> set syscall_insn "\[ \t\](swi|svc)\[ \t\]"
> } else {
>
> base-commit: 5541bfdc97936581c0ead915e9117e22f21bdb12
> --
> 2.36.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-31 8:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-30 16:59 [pushed] gdb/testsuite: fix gdb.trace/signal.exp on x86 Simon Marchi
2022-05-31 8:24 ` Andrew Burgess
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).