public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Youling Tang <tangyouling@loongson.cn>
Cc: gdb-patches@sourceware.org,  "Maciej W. Rozycki" <macro@orcam.me.uk>
Subject: Re: [PATCH] gdb: mips: Fix large-frame.exp test case failure
Date: Wed, 16 Mar 2022 10:40:21 -0600	[thread overview]
Message-ID: <875yodkg0a.fsf@tromey.com> (raw)
In-Reply-To: <1647307310-21454-1-git-send-email-tangyouling@loongson.cn> (Youling Tang's message of "Tue, 15 Mar 2022 09:21:50 +0800")

Hi.  Thank you for the patch.

>> The disassembly of the above func function shows that we may use instructions
>> such as daddiu/daddu, so add "daddiu $gp,$gp,n", "daddu $gp,$gp,$t9" and
>> "daddu $gp,$t9,$gp" to the mips32_scan_prologue function to fix the large-frame.exp
>> test case.

Since I don't know the MIPS architecture, my main question for this kind
of patch is whether this applies to the whole MIPS family, or whether it
somehow depends on some micro-architecture.

If it applies universally, or if it can't hurt other forms of MIPS, then
the patch itself looks good to me and you can go ahead.

thanks,
Tom

  reply	other threads:[~2022-03-16 16:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15  1:21 Youling Tang
2022-03-16 16:40 ` Tom Tromey [this message]
2022-03-16 18:36   ` Maciej W. Rozycki
2022-03-16 20:30     ` Tom Tromey
2022-05-10 21:13       ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yodkg0a.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@orcam.me.uk \
    --cc=tangyouling@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).