Re: [PATCHv2 0/5] Fixes for passing arguments to gdbserver

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> Some fixes for passing arguments to gdbserver.
>
> This all looks good to me.  Thanks for working on this.
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=28392
> points to this series:
> https://sourceware.org/pipermail/gdb-patches/2021-October/182723.html
>
> We really do need a patch tracker... the current situation is not good.
>
> Anyway I wonder how your patches compare.

So I took a look at this older series, and got it compiling.  It is a
super-set of my changes.

On the whole the older series looks really promising, however, it does
change the vRun remote packet, which I don't think is acceptable as it
was initially suggested[1].

I think this series from me does still offer some value, so I'm going to
go ahead and merge it, though I've acknowledged the author of the original
series with a Co-Authored-By tag, though I had not read that series when
I created my work.

When I get a chance, I'll try to revisit the older series and see what
can be done with it.

[1] All arguments are now passed as a single string within the vRun
rather than a vector of arguments.  I don't think this is going to be
acceptable.  If this really is the only way to solve the quoting problem
then, at a minimum, we'd need a feature flag to indicate this change in
behaviour.


>
> Approved-By: Tom Tromey <tom@tromey.com>
>

I removed the stray 'verbose' output from patch #4, and pushed this
series.

Thanks,
Andrew