From: Andreas Schwab <schwab@suse.de>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] gdbserver: fix handling of single quote arguments
Date: Wed, 27 Sep 2023 15:01:33 +0200 [thread overview]
Message-ID: <mvmfs2zrcr6.fsf@suse.de> (raw)
In-Reply-To: <2b98ca58e47638b4760d86bd6e1fa9a9a79fa2ad.1695817255.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Wed, 27 Sep 2023 13:21:14 +0100")
On Sep 27 2023, Andrew Burgess via Gdb-patches wrote:
> In this commit I propose removing the specific code that adds what I
> believe is a stray backslash. I've extended an existing test to cover
> this case, and I now see identical behaviour when using an
> extended-remote target as with the native target.
It seems like arguments containing newlines, and a trailing empty
argument are also mishandled.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2023-09-27 13:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 12:21 Andrew Burgess
2023-09-27 13:01 ` Andreas Schwab [this message]
2023-09-27 17:27 ` [PATCHv2 0/5] Fixes for passing arguments to gdbserver Andrew Burgess
2023-09-27 17:27 ` [PATCHv2 1/5] gdbserver: fix handling of single quote arguments Andrew Burgess
2023-09-27 17:27 ` [PATCHv2 2/5] gdbserver: fix handling of trailing empty argument Andrew Burgess
2023-09-27 17:27 ` [PATCHv2 3/5] gdbserver: handle newlines in inferior arguments Andrew Burgess
2023-09-27 17:27 ` [PATCHv2 4/5] gdbserver: cleanup in handle_v_run Andrew Burgess
2023-10-03 19:13 ` Tom Tromey
2023-10-04 14:40 ` Andrew Burgess
2023-10-04 19:35 ` Tom Tromey
2023-09-27 17:27 ` [PATCHv2 5/5] gdb/testsuite: cleanup in gdb.base/args.exp Andrew Burgess
2023-10-05 16:17 ` Tom Tromey
2023-10-05 16:18 ` [PATCHv2 0/5] Fixes for passing arguments to gdbserver Tom Tromey
2023-10-06 12:15 ` Andrew Burgess
2023-10-06 12:56 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmfs2zrcr6.fsf@suse.de \
--to=schwab@suse.de \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).