From: Tom Tromey <tom@tromey.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Correctly handle forward DIE references in scanner
Date: Mon, 15 May 2023 08:48:53 -0600 [thread overview]
Message-ID: <877ct93b1m.fsf@tromey.com> (raw)
In-Reply-To: <20230501221057.2375790-1-tom@tromey.com> (Tom Tromey's message of "Mon, 1 May 2023 16:10:57 -0600")
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> The cooked index scanner has special code to handle forward DIE
Tom> references. However, a bug report lead to the discovery that this
Tom> code does not work -- the "deferred_entry::spec_offset" field is
Tom> written to but never used, i.e., the lookup is done using the wrong
Tom> key.
Tom> This patch fixes the bug and adds a regression test.
Tom> The test in the bug itself used a thread_local variable, which
Tom> provoked a failure at runtime. This test instead uses "maint print
Tom> objfiles" and then inspects to ensure that the entry in question has a
Tom> parent. This lets us avoid a clang dependency in the test.
Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30271
I'm going check this in on master and gdb-13 now.
Tom
next prev parent reply other threads:[~2023-05-15 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 22:10 Tom Tromey
2023-05-15 14:48 ` Tom Tromey [this message]
2023-05-15 15:16 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ct93b1m.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).