* [PATCH] Remove a use of pagination_enabled
@ 2023-01-28 15:25 Tom Tromey
2023-02-14 20:54 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-01-28 15:25 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
I noticed that the TUI temporarily sets pagination_enabled and
gdb_stdout in one spot. However, I don't believe these settings are
necessary here, as a ui_file is passed to
gdbarch_print_registers_info. This patch removes these settings.
---
gdb/tui/tui-regs.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 3e794aed224..50a238401df 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -91,12 +91,6 @@ tui_register_format (frame_info_ptr frame, int regnum)
/* Expand tabs into spaces, since ncurses on MS-Windows doesn't. */
tab_expansion_file stream;
-
- scoped_restore save_pagination
- = make_scoped_restore (&pagination_enabled, false);
- scoped_restore save_stdout
- = make_scoped_restore (&gdb_stdout, &stream);
-
gdbarch_print_registers_info (gdbarch, &stream, frame, regnum, 1);
/* Remove the possible \n. */
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove a use of pagination_enabled
2023-01-28 15:25 [PATCH] Remove a use of pagination_enabled Tom Tromey
@ 2023-02-14 20:54 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2023-02-14 20:54 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
Tom> I noticed that the TUI temporarily sets pagination_enabled and
Tom> gdb_stdout in one spot. However, I don't believe these settings are
Tom> necessary here, as a ui_file is passed to
Tom> gdbarch_print_registers_info. This patch removes these settings.
I'm checking this in now.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-14 20:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-28 15:25 [PATCH] Remove a use of pagination_enabled Tom Tromey
2023-02-14 20:54 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).