Re: [PATCH] gdb: add a file event mask parameter to add_file_handler

[Tom Tromey <tom@tromey.com>]

>> Is there ever a situation where this can happen and it is not a bug in
>> the caller?  I am wondering if this ought to be an assert instead.

Patrick> Yes. In Insight, command input from stdin is disabled by setting
main_ui-> input_fd to -1. A later call to register_file_handler from 
Patrick> async_enable_stdin causes add_file_handler to be called with fd =
Patrick> -1. Maybe I should add a comment for this.

I took this same approach in my DAP implementation, which is why I
changed gdb to always call the 'ui' methods to manipulate the event
handlers.  In my patch I then change these methods to check for the -1
case.

I can submit this bit separately next week.
Or you can do it, it's trivial.

Patrick> I thought so too and did try to use enum_flags! Unfortunately the same
Patrick> int field (file_handler::mask) stores either these bits in case of 
Patrick> select use, or a poll mask as defined by the system when poll is used.

Ok, I see.

Tom