From: Tom Tromey <tromey@adacore.com>
To: Patrick Monnerat <patrick@monnerat.net>
Cc: Tom Tromey <tromey@adacore.com>,
Patrick Monnerat via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: add a file event mask parameter to add_file_handler
Date: Wed, 31 Aug 2022 10:51:44 -0600 [thread overview]
Message-ID: <874jxs9x0f.fsf@tromey.com> (raw)
In-Reply-To: <693da8b0-9f7d-2a62-8e99-7e64a8dc5593@monnerat.net> (Patrick Monnerat's message of "Wed, 31 Aug 2022 12:47:10 +0200")
Patrick> This is great! I applied your changes to Insight and dropped the fd<0
Patrick> test in add_file_handler with total success.
Patrick> I'll soon submit version 2 of my patch with the fd<0 test removed, and
Patrick> an updated test for mask==0 (this case should call
Patrick> delete_file_handler).
Patrick> This would have to be pushed after your patch, of course!
Patrick> Thanks a lot.
No problem, and thanks for trying it out.
I'm going to check it in now.
Tom
prev parent reply other threads:[~2022-08-31 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 17:46 Patrick Monnerat
2022-08-23 19:09 ` Tom Tromey
2022-08-24 15:26 ` Patrick Monnerat
2022-08-24 17:26 ` Tom Tromey
2022-08-30 17:34 ` Tom Tromey
2022-08-31 10:47 ` Patrick Monnerat
2022-08-31 16:51 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jxs9x0f.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=patrick@monnerat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).