Re: [PATCH] Add gdb.free_objfile event registry

[Tom Tromey <tromey@adacore.com>]

>> +   Copyright 2010-2022 Free Software Foundation, Inc.

Lancelot> Is the 2010 intentional?  It looks that this file is copied from
Lancelot> gdb.base/catch-load.c which is marked 2012-2022.

I changed it to just 2022.

>> +/* This is updated by the .exp file.  */
>> +char *libname = "catch-load-so.so";

Lancelot> To be "consistent" with other files which uses this pattern, shouldn't
Lancelot> the default libname reflect the test name? Something like
Lancelot> py-event-load-so.so I guess.  Later in the test you use
Lancelot> "py-events-shlib.so" as actual libname.

I updated this.

>> +clean_restart $testfile
>> +
>> +if {![runto_main]} {
>> +    return
>> +}
>> +
>> +if { [skip_python_tests] } { return }

Lancelot> I guess that this skip check can be moved above (together with the
Lancelot> skip_shlib_tests), so on target which skip python tests we do not bother
Lancelot> compiling the test program.  WDYT?

Unfortunately, skip_python_tests requires that gdb already be running.

I'm going to check in the updated patch now.

Tom