From: Andrew Burgess <aburgess@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: riscv: Fix newlib issue with brk syscall
Date: Fri, 12 Apr 2024 11:55:59 +0100 [thread overview]
Message-ID: <878r1i6e9s.fsf@redhat.com> (raw)
In-Reply-To: <AS8P193MB12855E12BC95017B57DEA868E4062@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM>
Bernd Edlinger <bernd.edlinger@hotmail.de> writes:
> There is an issue with riscv newlib which uses
> a brk syscall when malloc is used, and when
> this syscall is not implemented, the malloc fails.
> This adds a simple handling for this syscall
> in order to make newlib happy.
> ---
> sim/riscv/sim-main.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
> index 9c0d070aa60..4e3672505c6 100644
> --- a/sim/riscv/sim-main.c
> +++ b/sim/riscv/sim-main.c
> @@ -30,6 +30,7 @@
> #include "sim-main.h"
> #include "sim-signal.h"
> #include "sim-syscall.h"
> +#include "target-newlib-syscall.h"
>
> #include "opcode/riscv.h"
>
> @@ -629,6 +630,14 @@ execute_i (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op)
> break;
> case MATCH_ECALL:
> TRACE_INSN (cpu, "ecall;");
> + if (riscv_cpu->a7 == TARGET_NEWLIB_RISCV_SYS_brk)
> + {
> + TRACE_SYSCALL (cpu, "brk[%i](%#lx)", TARGET_NEWLIB_RISCV_SYS_brk,
> + (long)riscv_cpu->a0);
> + if (riscv_cpu->a0 == 0)
> + riscv_cpu->a0 = DEFAULT_MEM_SIZE / 2;
> + break;
> + }
This doesn't seem like the right solution. I would have expected some
changes in sim/common/syscall.c in the function cb_syscall. This would
mean that the syscall would be handled via the sim_syscall call below.
Thanks,
Andrew
> riscv_cpu->a0 = sim_syscall (cpu, riscv_cpu->a7, riscv_cpu->a0,
> riscv_cpu->a1, riscv_cpu->a2, riscv_cpu->a3);
> break;
> --
> 2.25.1
next prev parent reply other threads:[~2024-04-12 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 7:17 Bernd Edlinger
2024-04-12 10:55 ` Andrew Burgess [this message]
2024-04-12 11:41 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r1i6e9s.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=bernd.edlinger@hotmail.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).