From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Specialize std::hash for ptid_t
Date: Mon, 11 Sep 2023 10:35:19 -0600 [thread overview]
Message-ID: <878r9cllbs.fsf@tromey.com> (raw)
In-Reply-To: <99e5e4c7-9530-4eaa-8062-c13abb66b7b2@polymtl.ca> (Simon Marchi's message of "Mon, 11 Sep 2023 11:25:09 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> When searching on that topic, I found some sources advising against
Simon> opening namespace std, like this one:
...
Sounds good, here's v2.
Tom
commit 1d5a09c85bf97846438246397aaf4aae360c3783
Author: Tom Tromey <tromey@adacore.com>
Date: Mon Sep 11 08:45:37 2023 -0600
Specialize std::hash for ptid_t
This changes hash_ptid to instead be a specialization of std::hash.
This makes it a little easier to use with standard containers.
diff --git a/gdb/inferior.h b/gdb/inferior.h
index 04672582984..29c90d15efa 100644
--- a/gdb/inferior.h
+++ b/gdb/inferior.h
@@ -462,7 +462,7 @@ class inferior : public refcounted_object,
/* A map of ptid_t to thread_info*, for average O(1) ptid_t lookup.
Exited threads do not appear in the map. */
- std::unordered_map<ptid_t, thread_info *, hash_ptid> ptid_thread_map;
+ std::unordered_map<ptid_t, thread_info *> ptid_thread_map;
/* Returns a range adapter covering the inferior's threads,
including exited threads. Used like this:
diff --git a/gdb/regcache.c b/gdb/regcache.c
index 9b71931bb0b..91b20b7a2a2 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -329,7 +329,7 @@ reg_buffer::assert_regnum (int regnum) const
regcaches, associated to different gdbarches). */
using ptid_regcache_map
- = std::unordered_multimap<ptid_t, regcache_up, hash_ptid>;
+ = std::unordered_multimap<ptid_t, regcache_up>;
/* Type holding regcaches for a given pid. */
diff --git a/gdbsupport/ptid.h b/gdbsupport/ptid.h
index aa296b83181..f8644d47633 100644
--- a/gdbsupport/ptid.h
+++ b/gdbsupport/ptid.h
@@ -157,9 +157,8 @@ class ptid_t
tid_type m_tid;
};
-/* Functor to hash a ptid. */
-
-struct hash_ptid
+template<>
+struct std::hash<ptid_t>
{
size_t operator() (const ptid_t &ptid) const
{
next prev parent reply other threads:[~2023-09-11 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 14:47 Tom Tromey
2023-09-11 15:25 ` Simon Marchi
2023-09-11 16:35 ` Tom Tromey [this message]
2023-09-11 17:14 ` Simon Marchi
2023-09-14 19:14 ` Vaseeharan Vinayagamoorthy
2023-09-14 19:33 ` Tom Tromey
2023-09-14 22:34 ` Vaseeharan Vinayagamoorthy
2023-09-15 0:59 ` Simon Marchi
2023-09-15 13:15 ` Tom Tromey
2023-09-15 13:56 ` Simon Marchi
2023-09-15 16:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r9cllbs.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).