From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tromey@adacore.com>
Cc: Vaseeharan Vinayagamoorthy <Vaseeharan.Vinayagamoorthy@arm.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Specialize std::hash for ptid_t
Date: Fri, 15 Sep 2023 09:56:12 -0400 [thread overview]
Message-ID: <8e434b3e-2909-48dc-9a77-9e78c40ea57b@polymtl.ca> (raw)
In-Reply-To: <871qezh92h.fsf@tromey.com>
On 9/15/23 09:15, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> So, Tom's patch LGTM (sorry for suggesting the other form, I didn't know
> Simon> old gccs didn't like it).
>
> I don't think we know whether that patch works -- just that gcc 7 does.
>
> Tom
I have a build directory with gcc 4.8, I just tried, your patch fixes
things. So:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Thanks,
Simon
next prev parent reply other threads:[~2023-09-15 13:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 14:47 Tom Tromey
2023-09-11 15:25 ` Simon Marchi
2023-09-11 16:35 ` Tom Tromey
2023-09-11 17:14 ` Simon Marchi
2023-09-14 19:14 ` Vaseeharan Vinayagamoorthy
2023-09-14 19:33 ` Tom Tromey
2023-09-14 22:34 ` Vaseeharan Vinayagamoorthy
2023-09-15 0:59 ` Simon Marchi
2023-09-15 13:15 ` Tom Tromey
2023-09-15 13:56 ` Simon Marchi [this message]
2023-09-15 16:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e434b3e-2909-48dc-9a77-9e78c40ea57b@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=Vaseeharan.Vinayagamoorthy@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).