From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 6/7] Remove "highbound" parameter from value_array
Date: Tue, 29 Aug 2023 12:01:57 -0600 [thread overview]
Message-ID: <878r9tsp62.fsf@tromey.com> (raw)
In-Reply-To: <0999f314-3565-4475-acba-6da367fc9673@polymtl.ca> (Simon Marchi's message of "Tue, 29 Aug 2023 13:53:05 -0400")
>> - for (idx = 1; idx < nelem; idx++)
>> + for (idx = 1; idx < elemvec.size (); idx++)
>> {
>> if (type_length_units (elemvec[idx]->enclosing_type ())
>> != typelength)
Simon> I don't know if you want to make that change, but that loop can become
Simon> a range for loop.
I did this in v3.
Tom
next prev parent reply other threads:[~2023-08-29 18:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 15:34 [PATCH v2 0/7] Small cleanups in array_operation::evaluate Tom Tromey
2023-08-29 15:34 ` [PATCH v2 1/7] Use gdb::array_view for value_array Tom Tromey
2023-08-29 15:34 ` [PATCH v2 2/7] Declare 'tem' in loop header in array_operation::evaluate Tom Tromey
2023-08-29 15:34 ` [PATCH v2 3/7] Hoist array bounds check " Tom Tromey
2023-08-29 15:34 ` [PATCH v2 4/7] Remove redundant variable from array_operation::evaluate Tom Tromey
2023-08-29 15:34 ` [PATCH v2 5/7] Remove another " Tom Tromey
2023-08-29 15:34 ` [PATCH v2 6/7] Remove "highbound" parameter from value_array Tom Tromey
2023-08-29 17:53 ` Simon Marchi
2023-08-29 18:01 ` Tom Tromey [this message]
2023-08-29 15:34 ` [PATCH v2 7/7] More renames in array_operation::evaluate Tom Tromey
2023-08-29 15:58 ` [PATCH v2 0/7] Small cleanups " John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878r9tsp62.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).