From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Lancelot SIX <lsix@lancelotsix.com>,
Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH] gdb/amdgpu: provide dummy implementation of gdbarch_return_value_as_value
Date: Tue, 07 Mar 2023 12:20:18 -0700 [thread overview]
Message-ID: <878rg8s70t.fsf@tromey.com> (raw)
In-Reply-To: <5f905345-15a1-d7e0-f8b5-221997fcd1ac@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 7 Mar 2023 09:47:15 -0500")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> I think that Pedro hinted that we would need this anyway at some point,
Simon> for functions that don't follow a defined ABI. So, I think it would
Simon> make sense, but we need to update the core of GDB to handle that
Simon> response.
Can we even detect this situation?
E.g., PR 30090 turned out to have a function with a nonstandard ABI, and
in the end I just xfail'd the test.
Simon> And I'm not too familiar with this area, so I don't know how
Simon> much work this represents. But if we know we're going to need this
Simon> anyway, I might as well give it a shot.
There aren't many callers of the gdbarch hooks so I guess you could just
track them all down and see what needs to be done at each one. There's
definitely already code to handle the lack of a return value, so it
seems like it may not be too hard.
Tom
next prev parent reply other threads:[~2023-03-07 19:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 21:46 Simon Marchi
2023-03-07 10:45 ` Lancelot SIX
2023-03-07 14:47 ` Simon Marchi
2023-03-07 19:12 ` Lancelot SIX
2023-03-07 19:20 ` Tom Tromey [this message]
2023-03-07 20:32 ` Simon Marchi
2023-03-07 20:44 ` Tom Tromey
2023-03-07 20:33 ` Lancelot SIX
2023-03-07 20:44 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rg8s70t.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).