From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 1/3] gdb: small simplification in dwarf2_locexpr_baton_eval
Date: Fri, 01 Apr 2022 13:11:13 -0600 [thread overview]
Message-ID: <878rsomxf2.fsf@tromey.com> (raw)
In-Reply-To: <d1f4dcf67c38644011ff126cea33bb98f014dd6c.1648036751.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Wed, 23 Mar 2022 11:59:56 +0000")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> While examining the dwarf expression evaluator, I noticed that in
Andrew> dwarf2_locexpr_baton_eval, whenever push_initial_value is true, the
Andrew> addr_stack will never be nullptr.
Andrew> This allows for a small cleanup, replacing an if/then/else with an
Andrew> assertion.
Seems reasonable.
Tom
next prev parent reply other threads:[~2022-04-01 19:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 17:57 [PATCH] Support for Fortran's ASSUMED RANK Potharla, Rupesh
2022-01-21 19:07 ` Andrew Burgess
2022-01-22 7:17 ` Potharla, Rupesh
2022-01-28 7:49 ` Potharla, Rupesh
2022-02-06 13:39 ` Andrew Burgess
2022-03-16 11:54 ` Potharla, Rupesh
2022-03-23 11:58 ` Andrew Burgess
2022-03-23 11:59 ` [PATCH 0/3] Fortran assumed rank array support Andrew Burgess
2022-03-23 11:59 ` [PATCH 1/3] gdb: small simplification in dwarf2_locexpr_baton_eval Andrew Burgess
2022-04-01 19:11 ` Tom Tromey [this message]
2022-03-23 11:59 ` [PATCH 2/3] gdb/dwarf: pass an array of values to the dwarf evaluator Andrew Burgess
2022-04-01 19:16 ` Tom Tromey
2022-03-23 11:59 ` [PATCH 3/3] gdb: add support for Fortran's ASSUMED RANK arrays Andrew Burgess
2022-04-01 19:38 ` Tom Tromey
2022-04-03 16:21 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rsomxf2.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).