Re: [PATCH 3/3] gdb: add support for Fortran's ASSUMED RANK arrays

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> An alternative approach would be to make the rank value a
Andrew> gdb::optional, however, this ends up adding a bunch of complexity to
Andrew> the code (e.g. having to conditionally build the array to pass to
Andrew> dwarf2_evaluate_property, and handling the 'rank - 1' in
Andrew> resolve_dynamic_array_or_string_1) so I haven't done that, but could,
Andrew> if people think that would be a better approach.

I don't really have an opinion on this, but didn't want to just
completely ignore it either.

I did notice one oddity.

Andrew> +      rank = 1;
Andrew> +
Andrew> +      for (struct type *tmp_type = TYPE_TARGET_TYPE (type);
Andrew> +	   check_typedef (tmp_type)->code () == TYPE_CODE_ARRAY;
Andrew> +	   tmp_type = TYPE_TARGET_TYPE (tmp_type))
Andrew> +	++rank;

This loop calls check_typedef in the condition, but not when updating
tmp_type.  Probably the update clause should also use check_typedef.
I don't know if Fortran even has typedefs, but its safe to do this.

Tom