Re: [PATCHv2 1/2] gdb: use a range based for loop when iterating over an array

[Andrew Burgess <aburgess@redhat.com>]

aburgess@redhat.com (Andrew Burgess) writes:

> Make use of a range based for loop to iterate over a static global
> array, removing the need to have a null entry at the end of the
> array.
>
> There should be no user visible changes after this commit.

I've gone ahead and pushed just this patch from this series.

Thanks,
Andrew



> ---
>  gdb/python/py-type.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/gdb/python/py-type.c b/gdb/python/py-type.c
> index 8b17b70fbe3..15d73fe94e4 100644
> --- a/gdb/python/py-type.c
> +++ b/gdb/python/py-type.c
> @@ -113,7 +113,6 @@ static struct pyty_code pyty_codes[] =
>    ENTRY (TYPE_CODE_NAMESPACE),
>    ENTRY (TYPE_CODE_DECFLOAT),
>    ENTRY (TYPE_CODE_INTERNAL_FUNCTION),
> -  { TYPE_CODE_UNDEF, NULL }
>  };
>  
>  \f
> @@ -1444,8 +1443,6 @@ _initialize_py_type ()
>  int
>  gdbpy_initialize_types (void)
>  {
> -  int i;
> -
>    if (PyType_Ready (&type_object_type) < 0)
>      return -1;
>    if (PyType_Ready (&field_object_type) < 0)
> @@ -1453,10 +1450,9 @@ gdbpy_initialize_types (void)
>    if (PyType_Ready (&type_iterator_object_type) < 0)
>      return -1;
>  
> -  for (i = 0; pyty_codes[i].name; ++i)
> +  for (const auto &item : pyty_codes)
>      {
> -      if (PyModule_AddIntConstant (gdb_module, pyty_codes[i].name,
> -				   pyty_codes[i].code) < 0)
> +      if (PyModule_AddIntConstant (gdb_module, item.name, item.code) < 0)
>  	return -1;
>      }
>  
> -- 
> 2.25.4