From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tom@tromey.com>,
Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCHv3 0/3] Add Type.is_scalar and Type.is_signed properties
Date: Mon, 07 Mar 2022 19:43:49 +0000 [thread overview]
Message-ID: <87o82hwnt6.fsf@redhat.com> (raw)
In-Reply-To: <877d9ioow4.fsf@tromey.com>
Tom Tromey <tom@tromey.com> writes:
>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> Thanks for all the feedback on V1, and V2. Additionally, Simon gave
> Andrew> some awesome suggestions on IRC
>
> Andrew> The new V3 series is a complete rewrite, main points are:
>
> Andrew> - New Type.is_scalar property in patch #1,
>
> Andrew> - Now have a Type.is_signed property (patch #2), which is either
> Andrew> True or False. Attempting to read this property on a non-scalar
> Andrew> type will raise a ValueError.
>
> Andrew> - Finally, patch #3 adds a test for to cover the 'char' is different
> Andrew> to 'signed char' and 'unsigned char' issue. This characteristic
> Andrew> should be detected by simply comparing types.
>
> Andrew> Thoughts?
>
> It all looks reasonable to me. Thank you.
I pushed this series.
Thanks,
Andrew
prev parent reply other threads:[~2022-03-07 19:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 16:06 [PATCH 0/2] Add new gdb.Type.signedness attribute Andrew Burgess
2021-12-03 16:06 ` [PATCH 1/2] gdb: use ARRAY_SIZE for iterating over an array Andrew Burgess
2021-12-03 21:02 ` Tom Tromey
2021-12-03 16:06 ` [PATCH 2/2] gdb/python: add Type.signedness attribute Andrew Burgess
2021-12-03 21:05 ` Tom Tromey
2021-12-06 14:08 ` [PATCHv2 0/2] Add new gdb.Type.signedness attribute Andrew Burgess
2021-12-06 14:08 ` [PATCHv2 1/2] gdb: use a range based for loop when iterating over an array Andrew Burgess
2022-02-24 16:40 ` Andrew Burgess
2021-12-06 14:08 ` [PATCHv2 2/2] gdb/python: add Type.signedness attribute Andrew Burgess
2021-12-08 3:13 ` Simon Marchi
2021-12-08 9:56 ` Andrew Burgess
2021-12-08 10:19 ` [PATCHv3 " Andrew Burgess
2021-12-08 13:35 ` [PATCHv2 " Simon Marchi
2021-12-08 16:56 ` Tom Tromey
2021-12-09 12:34 ` Andrew Burgess
2021-12-07 19:26 ` [PATCHv2 0/2] Add new gdb.Type.signedness attribute Tom Tromey
2022-02-25 13:55 ` [PATCHv3 0/3] Add Type.is_scalar and Type.is_signed properties Andrew Burgess
2022-02-25 13:55 ` [PATCHv3 1/3] gdb/python: add Type.is_scalar property Andrew Burgess
2022-02-25 14:11 ` Eli Zaretskii
2022-02-25 13:55 ` [PATCHv3 2/3] gdb/python: add Type.is_signed property Andrew Burgess
2022-02-25 14:12 ` Eli Zaretskii
2022-02-25 13:55 ` [PATCHv3 3/3] gdb/testsuite: add new test for comparing char types in Python Andrew Burgess
[not found] ` <cover.1645788436.git.aburgess__7628.6948680476$1645797489$gmane$org@redhat.com>
2022-02-25 17:08 ` [PATCHv3 0/3] Add Type.is_scalar and Type.is_signed properties Tom Tromey
2022-03-07 19:43 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o82hwnt6.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).