public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Luis Machado <luis.machado@arm.com>
Cc: "Tom Tromey" <tromey@adacore.com>,
	gdb-patches@sourceware.org,
	"Kévin Le Gouguec" <legouguec@adacore.com>
Subject: Re: [PATCH] Strip trailing newlines from input string
Date: Thu, 11 Apr 2024 07:45:07 -0600	[thread overview]
Message-ID: <87a5m03tek.fsf@tromey.com> (raw)
In-Reply-To: <a83c3915-2fbd-4b70-92f6-11e3138d6a43@arm.com> (Luis Machado's message of "Tue, 9 Apr 2024 23:36:19 +0100")

Luis> Looks good to me.

Luis> Approved-By: Luis Machado <luis.machado@arm.com>
Luis> Tested-By: Luis Machado <luis.machado@arm.com>

Thanks.

Unfortunately the CI didn't like it, but I have no idea why.
In the gdb.log the echo output doesn't appear at all.

^[[?2004h(gdb) ^[[7mecho hello^[[m^M
^M^[[A(gdb) FAIL: gdb.base/paste-newline.exp: newline removed from paste

I don't know why this would happen or how to debug it.

Tom

  reply	other threads:[~2024-04-11 13:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 17:18 Tom Tromey
2024-04-09 22:36 ` Luis Machado
2024-04-11 13:45   ` Tom Tromey [this message]
2024-04-11 14:45     ` Luis Machado
2024-04-11 16:17       ` Thiago Jung Bauermann
2024-04-15 15:04         ` Tom Tromey
2024-04-15 18:21 ` [PP?] " Simon Marchi
2024-04-15 18:28   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5m03tek.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=legouguec@adacore.com \
    --cc=luis.machado@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).