Re: [PP?] [PATCH] Strip trailing newlines from input string

[Tom Tromey <tromey@adacore.com>]

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> On 4/8/24 1:18 PM, Tom Tromey wrote:
>> A co-worker noticed a strange situation where "target remote" would
>> fail due to a trailing newline in the address part of the command.
>> Eventually he tracked this down to the fact that he was pasting the
>> command into the terminal, and due to bracketed paste mode, the
>> newline was being preserved by readline.
>> 
>> It seems to me that we basically never want a trailing newline on a
>> gdb command, so this patch removes it when handling the readline
>> result.
>> 
>> Co-Authored-By: Kévin Le Gouguec <legouguec@adacore.com>

Simon> This caused a regression when quitting gdb with ctrl-D:

Simon> $ ./gdb -nx -q --data-directory=data-directory
Simon> (gdb) quit   <--- hit ctrl-D
Simon> /home/smarchi/src/binutils-gdb/gdb/event-top.c:257:23: runtime error: null pointer passed as argument 1, which is declared to never be null

Simon> Here, I have UBSan (I think?) that prints me a nice message, but
Simon> otherwise it segfaults.

Simon> I think this is caught by gdb.base/eof-exit.exp, I now see this test
Simon> failing on my CI.

Huh, I see it too.

I'll fix this, sorry about the breakage.

Tom