From: Tom Tromey <tom@tromey.com>
To: Lancelot SIX <lancelot.six@amd.com>
Cc: <gdb-patches@sourceware.org>, <tdevries@suse.de>
Subject: Re: [PATCH] Revert "gdb/compile: Use std::filesystem::remove_all in cleanup"
Date: Wed, 03 Apr 2024 08:59:52 -0600 [thread overview]
Message-ID: <87a5ma8pav.fsf@tromey.com> (raw)
In-Reply-To: <20240403144446.39094-1-lancelot.six@amd.com> (Lancelot SIX's message of "Wed, 3 Apr 2024 15:44:46 +0100")
>>>>> "Lancelot" == Lancelot SIX <lancelot.six@amd.com> writes:
Lancelot> This reverts commit 7bba0ad08576309763e3f41193eaa93025e10b8b.
Lancelot> Tom de Vries reported that 7bba0ad0857 (gdb/compile: Use
Lancelot> std::filesystem::remove_all in cleanup) broke builds with gcc-7.5.0
Lancelot> which mostly supports c++17, but not std::filesystem[1]. As this change
Lancelot> is not critical, revert it to maintain compatibility.
Thanks. Could you put the 'Bug:' tag into this so it's recorded in
bugzilla?
Sorry to say it but this is ok. I appreciate your quick turnaround on
it.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-04-03 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 14:44 Lancelot SIX
2024-04-03 14:59 ` Tom Tromey [this message]
2024-04-03 15:35 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ma8pav.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).