Re: [PATCH 3/3] Implement the notStopped DAP response

[Tom Tromey <tromey@adacore.com>]

>>>>> "Kévin" == Kévin Le Gouguec <legouguec@adacore.com> writes:

>> +# True when the inferior is thought to be running, False otherwise.
>> +# This may be accessed from any thread, which can be racy.  However,
>> +# this unimportant because this global is only used for the
>> +# 'notStopped' response, which itself is inherently racy.
>> +inferior_running = False

Kévin> Out of curiosity, could `inferior_thread ()->state` have helped here?
Kévin> (Exposing it as a gdb.Inferior method perhaps?)

Kévin> Not necessarily with the "racy" part; thinking more of the "keep a
Kévin> single source of truth" part (i.e. dispense with relying on event
Kévin> notifications).

Possibly, but it couldn't be called from a non-gdb thread, so we'd have
to send a message to the gdb thread and then a message back.

>> +        # Import this as late as possible.  FIXME.
>> +        from .events import inferior_running

Kévin> Assuming this is what the FIXME is about (apologies if not): an
Kévin> alternative could be doing a bare `import .events`, then lookup
Kévin> `.events.inferior_running` in check().  Or defining an accessor function
Kévin> in .events and importing that instead of this global.

The problem is a circular import, as events imports from server.
I may just remove this comment?  Not sure.

Originally here I was thinking of putting more event listeners in
server.py, but it seemed strange not to just reuse the existing ones.

Tom