From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Automatically run (most) DAP requests in gdb thread
Date: Mon, 13 Nov 2023 13:59:18 +0100 [thread overview]
Message-ID: <CAJVr-ENnNy73L_HXpfW7vHd9UmTyH_BUCPc3yhr0EV9oQM3wFA@mail.gmail.com> (raw)
In-Reply-To: <20231107-dap-not-stopped-v1-1-3d91c935255d@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
On Tue, Nov 7, 2023 at 7:29 PM Tom Tromey <tromey@adacore.com> wrote:
> Nearly every DAP request implementation forwards its work to the gdb
> thread, using send_gdb_with_response. This patch refactors the
> 'request' decorator to make this automatic, and to provide some
> parameters so that the unusual requests can express their needs as
> well.
>
> In a few spots this simplifies the code by removing an unnecessary
> helper function. This could be done in more places as well if we
> wanted.
>
> The main motivation for this patch is that I thought it would be
> helpful for cancellation. I am still working on that, but meanwhile
> the parameterization of 'request' makes it easy to handle the
> 'notStopped' response as well.
>
> I can confirm this commit introduces no regressions with Fedora Rawhide
ppc64le. Also I like the
simplification this brings.
Thanks,
Alexandra
next prev parent reply other threads:[~2023-11-13 12:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 18:29 [PATCH 0/3] Implement the DAP notStopped response Tom Tromey
2023-11-07 18:29 ` [PATCH 1/3] Automatically run (most) DAP requests in gdb thread Tom Tromey
2023-11-13 12:59 ` Alexandra Petlanova Hajkova [this message]
2023-11-07 18:29 ` [PATCH 2/3] Remove ExecutionInvoker Tom Tromey
2023-11-13 13:57 ` Alexandra Petlanova Hajkova
2023-11-07 18:29 ` [PATCH 3/3] Implement the notStopped DAP response Tom Tromey
2023-11-08 8:23 ` Kévin Le Gouguec
2023-11-10 14:52 ` Tom Tromey
2023-11-10 15:14 ` Kévin Le Gouguec
2023-11-10 15:18 ` Tom Tromey
2023-11-10 15:08 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJVr-ENnNy73L_HXpfW7vHd9UmTyH_BUCPc3yhr0EV9oQM3wFA@mail.gmail.com \
--to=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).