From: Tom Tromey <tom@tromey.com>
To: Ciaran Woodward <ciaranwoodward@xmos.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix scoped_value_mark not working with empty value chain
Date: Wed, 24 May 2023 13:00:50 -0600 [thread overview]
Message-ID: <87a5xty2ot.fsf@tromey.com> (raw)
In-Reply-To: <PAXPR09MB5583501A5BABF34867A616E5B9439@PAXPR09MB5583.eurprd09.prod.outlook.com> (Ciaran Woodward's message of "Mon, 22 May 2023 14:42:18 +0000")
>>>>> "Ciaran" == Ciaran Woodward <ciaranwoodward@xmos.com> writes:
Ciaran> The scoped_value_mark helper class was setting its internal
Ciaran> mark value to NULL to indicate that the value chain had already
Ciaran> been freed to mark.
Thanks for finding this.
Ciaran> scoped_value_mark ()
Ciaran> : m_value (value_mark ())
Ciaran> + , m_freed (false)
These days we prefer inline initialization...
Ciaran> + bool m_freed;
... i.e., adding " = false" here.
This is ok with this change.
If you don't have commit access (I didn't look), just send a v2 and I
will apply it.
Tom
prev parent reply other threads:[~2023-05-24 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 14:42 Ciaran Woodward
2023-05-24 19:00 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5xty2ot.fsf@tromey.com \
--to=tom@tromey.com \
--cc=ciaranwoodward@xmos.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).