From: Tom Tromey <tromey@adacore.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>,
Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 3/3] Add name canonicalization for C
Date: Thu, 01 Dec 2022 10:56:46 -0700 [thread overview]
Message-ID: <87a647m2ht.fsf@tromey.com> (raw)
In-Reply-To: <87bkon1408.fsf@redhat.com> (Andrew Burgess's message of "Thu, 01 Dec 2022 16:29:43 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>> - {DW_AT_name {unsigned integer}}
>> + {DW_AT_name {unsigned int}}
Andrew> I notice that a few lines above this we also have:
Andrew> integer_label: DW_TAG_base_type {
Andrew> {DW_AT_byte_size 4 DW_FORM_sdata}
Andrew> {DW_AT_encoding @DW_ATE_signed}
Andrew> {DW_AT_name integer}
Andrew> }
Andrew> which seems to have the same int/integer misnaming, though I guess it
Andrew> isn't causing any problems. Maybe we should fix this anyway though,
Andrew> just for consistency?
Sure, no problem.
The reason "unsigned integer" causes a problem is that this
canonicalizes to "unsigned int integer". Maybe this is a bug in the
canonicalizer, though it's also weird/"impossible" input.
"integer" doesn't have this problem because it's just an ordinary
identifier.
Thanks for your reviews.
Tom
next prev parent reply other threads:[~2022-12-01 17:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-07 16:23 [PATCH 0/3] Fix over-eager CU expansion with new DWARF reader Tom Tromey
2022-11-07 16:23 ` [PATCH 1/3] Remove language check from dwarf2_compute_name Tom Tromey
2022-12-01 15:16 ` Andrew Burgess
2022-11-07 16:23 ` [PATCH 2/3] Refactor cooked_index::do_finalize Tom Tromey
2022-12-01 15:34 ` Andrew Burgess
2022-11-07 16:23 ` [PATCH 3/3] Add name canonicalization for C Tom Tromey
2022-12-01 16:06 ` Simon Marchi
2022-12-01 16:29 ` Andrew Burgess
2022-12-01 17:56 ` Tom Tromey [this message]
2022-12-01 18:16 ` Tom Tromey
2022-12-01 23:23 ` Andrew Burgess
2022-12-02 14:39 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a647m2ht.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).