From: Tom Tromey <tom@tromey.com>
To: "Aktemur, Tankut Baris via Gdb-patches" <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,
"Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
Subject: Re: [PATCH] gdbserver: use target_waitstatus::to_string in 'prepare_resume_reply'
Date: Tue, 20 Jun 2023 10:42:25 -0600 [thread overview]
Message-ID: <87bkha2iha.fsf@tromey.com> (raw)
In-Reply-To: <DM4PR11MB73031456C35445436B369C1FC45CA@DM4PR11MB7303.namprd11.prod.outlook.com> (Tankut Baris via Gdb-patches Aktemur's message of "Tue, 20 Jun 2023 15:38:42 +0000")
>> > Use the to_string method of target_waitstatus in
>> > 'prepare_resume_reply' for a more readable log message.
>>
>> Seems fine to me.
>> Reviewed-By: Tom Tromey <tom@tromey.com>
>>
>> Tom
> Thank you.
> Although the patch is relatively simple, a Reviewed-By is still
> not an Approved-By and thus I have not pushed the patch. Correct?
Sorry, here you go.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2023-06-20 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 11:17 Tankut Baris Aktemur
2023-06-20 14:06 ` Tom Tromey
2023-06-20 15:38 ` Aktemur, Tankut Baris
2023-06-20 16:42 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkha2iha.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).