[PATCH] gdbserver: use target_waitstatus::to_string in 'prepare_resume_reply'

[PATCH] gdbserver: use target_waitstatus::to_string in 'prepare_resume_reply'

[Tankut Baris Aktemur]

Use the to_string method of target_waitstatus in
'prepare_resume_reply' for a more readable log message.
---
 gdbserver/remote-utils.cc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gdbserver/remote-utils.cc b/gdbserver/remote-utils.cc
index f54bbab0243..722915d30f2 100644
--- a/gdbserver/remote-utils.cc
+++ b/gdbserver/remote-utils.cc
@@ -1053,8 +1053,9 @@ void
 prepare_resume_reply (char *buf, ptid_t ptid, const target_waitstatus &status)
 {
   client_state &cs = get_client_state ();
-  threads_debug_printf ("Writing resume reply for %s:%d",
-			target_pid_to_str (ptid).c_str (), status.kind ());
+  threads_debug_printf ("Writing resume reply for %s: %s",
+			target_pid_to_str (ptid).c_str (),
+			status.to_string ().c_str ());
 
   switch (status.kind ())
     {
-- 
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [PATCH] gdbserver: use target_waitstatus::to_string in 'prepare_resume_reply'

[Tom Tromey]

>>>>> Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> writes:

> Use the to_string method of target_waitstatus in
> 'prepare_resume_reply' for a more readable log message.

Seems fine to me.
Reviewed-By: Tom Tromey <tom@tromey.com>

Tom

RE: [PATCH] gdbserver: use target_waitstatus::to_string in 'prepare_resume_reply'

[Aktemur, Tankut Baris]

On Tuesday, June 20, 2023 4:06 PM, Tom Tromey wrote:
> >>>>> Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> > Use the to_string method of target_waitstatus in
> > 'prepare_resume_reply' for a more readable log message.
> 
> Seems fine to me.
> Reviewed-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thank you.

Although the patch is relatively simple, a Reviewed-By is still
not an Approved-By and thus I have not pushed the patch.  Correct?

-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Re: [PATCH] gdbserver: use target_waitstatus::to_string in 'prepare_resume_reply'

[Tom Tromey]

>> > Use the to_string method of target_waitstatus in
>> > 'prepare_resume_reply' for a more readable log message.
>> 
>> Seems fine to me.
>> Reviewed-By: Tom Tromey <tom@tromey.com>
>> 
>> Tom

> Thank you.

> Although the patch is relatively simple, a Reviewed-By is still
> not an Approved-By and thus I have not pushed the patch.  Correct?

Sorry, here you go.
Approved-By: Tom Tromey <tom@tromey.com>

Tom