public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH v2 8/9] Implement gdb.execute_mi
Date: Fri, 02 Jun 2023 13:19:02 -0600	[thread overview]
Message-ID: <87bkhxu0yh.fsf@tromey.com> (raw)
In-Reply-To: <3f4fa15a-29f0-f1bb-f824-fbe9d344c397@simark.ca> (Simon Marchi's message of "Mon, 29 May 2023 11:54:17 -0400")

Simon> My patch here:

Simon> https://inbox.sourceware.org/gdb-patches/48eb5ee9-53e1-f1df-b424-d08342c7e857@simark.ca/T/#m94825956483bc1d340da33ad4712752d3326fecf

Simon> conflicts with this patch, so I am taking a closer look at
Simon> gdb.execute_mi.  I think some things are missing from the gdb.execute_mi
Simon> implementation [...]

I just wanted to let you know I haven't dropped this.
I didn't look at it much but I hope to investigate a bit next week.

Simon>   (gdb) python gdb.execute_mi('-gdb-exit')

Simon> First, I think that the new mi_execute_command function should install
Simon> the mi interpreter as the current interpreter (or the command
Simon> interpreter, I don't really understand the distinction) such as code
Simon> down mi_execute_command gets the mi_interp object when calling
Simon> current_interpreter.  There are not a lot of commands getting the
Simon> current interpreter, but -gdb-exit is one of them.  I tried fixing this
Simon> quickly, but it's not just a oneliner.

I wouldn't mind disallowing -gdb-exit from execute_mi.  That's a
pathological case anyway.

I looked for calls to current_interpreter in the MI code but I don't see
many... though who knows what the core of gdb is doing.  In fact the
-gdb-exit one is the only one that seems to be part of a command.

Tom

  reply	other threads:[~2023-06-02 19:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-18 20:18 [PATCH v2 0/9] Implement the DAP "loadedSources" request Tom Tromey
2023-05-18 20:18 ` [PATCH v2 1/9] Use field_signed from Python MI commands Tom Tromey
2023-05-18 20:18 ` [PATCH v2 2/9] Use member initializers in mi_parse Tom Tromey
2023-05-18 20:18 ` [PATCH v2 3/9] Use accessor for mi_parse::args Tom Tromey
2023-05-18 20:18 ` [PATCH v2 4/9] Change mi_parse_argv to a method Tom Tromey
2023-05-18 20:18 ` [PATCH v2 5/9] Introduce "static constructor" for mi_parse Tom Tromey
2023-08-11 11:02   ` Andrew Burgess
2023-08-11 13:10     ` Tom Tromey
2023-08-11 15:06       ` Andrew Burgess
2023-05-18 20:18 ` [PATCH v2 6/9] Introduce mi_parse helper methods Tom Tromey
2023-05-18 20:18 ` [PATCH v2 7/9] Add second mi_parse constructor Tom Tromey
2023-05-18 20:18 ` [PATCH v2 8/9] Implement gdb.execute_mi Tom Tromey
2023-05-19  5:37   ` Eli Zaretskii
2023-05-29 15:54   ` Simon Marchi
2023-06-02 19:19     ` Tom Tromey [this message]
2023-06-08 20:16     ` Tom Tromey
2023-05-18 20:18 ` [PATCH v2 9/9] Implement DAP loadedSources request Tom Tromey
2023-05-23 19:46 ` [PATCH v2 0/9] Implement the DAP "loadedSources" request Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkhxu0yh.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).