Re: [PATCH v2 5/9] Introduce "static constructor" for mi_parse

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tromey@adacore.com> writes:

>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> Sorry to respond to such an old thread, but I ran into the
> Andrew> mi_parse::make code today.  From your commit message I don't see the
> Andrew> connection for why we need a static mi_parse::make function in order to
> Andrew> get rid of the set_args method.
>
> Andrew> For reference, I switched the code back to using constructors (but
> Andrew> didn't add back set_args), and I'm not seeing any regressions in
> Andrew> gdb.mi/* and gdb.python/*.
>
> Andrew> Could you expand on why this change is needed?
>
> I don't recall what exactly I was thinking when I wrote it.  It might
> have been a leftover from some other attempt to use unique_ptr to ensure
> there isn't a possibility of a leak.
>
> I think it's fine to switch it to constructors if that is convenient for
> you.

Thanks.  I'll CC you when I post the patch.  Just thought I'd ask first,
didn't want to look like I was just trying to revert your work :)

Thanks,
Andrew