* [PATCH][gdb/testsuite] Allow override of ASAN_OPTIONS in lib/gdb.exp
@ 2022-07-12 12:38 Tom de Vries
2022-07-15 16:03 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2022-07-12 12:38 UTC (permalink / raw)
To: gdb-patches
Hi,
Use set_sanitizer_default for ASAN_OPTIONS in lib/gdb.exp.
This allows us to override the default detect_leaks=0 setting, by manually
doing:
...
$ export ASAN_OPTIONS=detect_leaks=1
$ make check
...
Tested on x86_64-linux, by building with -fsanitize=address and running
test-case gdb.dwarf2/gdb-add-index.exp with and without
"export ASAN_OPTIONS=detect_leaks=1".
Any comments?
Thanks,
- Tom
[gdb/testsuite] Allow override of ASAN_OPTIONS in lib/gdb.exp
---
gdb/testsuite/lib/gdb.exp | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 698dd14504e..a8f25b5f0dd 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -25,13 +25,6 @@ if {$tool == ""} {
exit 2
}
-# If GDB is built with ASAN (and because there are leaks), it will output a
-# leak report when exiting as well as exit with a non-zero (failure) status.
-# This can affect tests that are sensitive to what GDB prints on stderr or its
-# exit status. Add `detect_leaks=0` to the ASAN_OPTIONS environment variable
-# (which will affect any spawned sub-process) to avoid this.
-append ::env(ASAN_OPTIONS) ",detect_leaks=0"
-
# Add VAR_ID=VAL to ENV_VAR, unless ENV_VAR already contains a VAR_ID setting.
proc set_sanitizer_default { env_var var_id val } {
@@ -58,6 +51,13 @@ proc set_sanitizer_default { env_var var_id val } {
set_sanitizer_default TSAN_OPTIONS suppressions \
$srcdir/../tsan-suppressions.txt
+# If GDB is built with ASAN (and because there are leaks), it will output a
+# leak report when exiting as well as exit with a non-zero (failure) status.
+# This can affect tests that are sensitive to what GDB prints on stderr or its
+# exit status. Add `detect_leaks=0` to the ASAN_OPTIONS environment variable
+# (which will affect any spawned sub-process) to avoid this.
+set_sanitizer_default ASAN_OPTIONS detect_leaks 0
+
# List of procs to run in gdb_finish.
set gdb_finish_hooks [list]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][gdb/testsuite] Allow override of ASAN_OPTIONS in lib/gdb.exp
2022-07-12 12:38 [PATCH][gdb/testsuite] Allow override of ASAN_OPTIONS in lib/gdb.exp Tom de Vries
@ 2022-07-15 16:03 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2022-07-15 16:03 UTC (permalink / raw)
To: Tom de Vries via Gdb-patches
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> Use set_sanitizer_default for ASAN_OPTIONS in lib/gdb.exp.
[...]
Tom> Any comments?
Seems fine to me. Thank you.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-15 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 12:38 [PATCH][gdb/testsuite] Allow override of ASAN_OPTIONS in lib/gdb.exp Tom de Vries
2022-07-15 16:03 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).