Re: [PATCH] gdbserver: remove unused variable

[Andrew Burgess <aburgess@redhat.com>]

Enze Li via Gdb-patches <gdb-patches@sourceware.org> writes:

> When building with clang 15, I got this error:
>
>   CXX    server.o
> server.cc:2985:10: error: variable 'new_argc' set but not used [-Werror,-Wunused-but-set-variable]
>   int i, new_argc;
>              ^
> Remove the unused variable to eliminate the error.

LGTM.  Please apply it.

Thanks,
Andrew

>
> Tested by rebuilding on x86_64-linux with clang 15.
> ---
>  gdbserver/server.cc | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
> index f9c02a9c6dac..c619206d5d2d 100644
> --- a/gdbserver/server.cc
> +++ b/gdbserver/server.cc
> @@ -2982,14 +2982,10 @@ handle_v_run (char *own_buf)
>    char *p, *next_p;
>    std::vector<char *> new_argv;
>    char *new_program_name = NULL;
> -  int i, new_argc;
> +  int i;
>  
> -  new_argc = 0;
>    for (p = own_buf + strlen ("vRun;"); p && *p; p = strchr (p, ';'))
> -    {
> -      p++;
> -      new_argc++;
> -    }
> +    p++;
>  
>    for (i = 0, p = own_buf + strlen ("vRun;"); *p; p = next_p, ++i)
>      {
> -- 
> 2.30.2