From: Tom Tromey <tromey@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Handle encoding failures in Windows thread names
Date: Tue, 26 Apr 2022 12:53:59 -0600 [thread overview]
Message-ID: <87bkwnoeuw.fsf@tromey.com> (raw)
In-Reply-To: <83r15qqvz6.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Apr 2022 18:47:41 +0300")
Eli> I suggest to explain in a comment how this code detects encoding
Eli> failures. The documentation of WideCharToMultiByte is not simple to
Eli> understand in this regard, and "used_default" is not expressive enough
Eli> to explain its role here, so I suggest not to rely on the reader to
Eli> know those subtleties.
I've added a comment and I'm checking this in.
Tom
next prev parent reply other threads:[~2022-04-26 18:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 14:39 Tom Tromey
2022-04-21 15:47 ` Eli Zaretskii
2022-04-26 18:53 ` Tom Tromey [this message]
2022-06-02 14:19 ` Jon Turney
2022-06-02 14:33 ` Tom Tromey
2022-06-02 19:29 ` Jon Turney
2022-06-03 16:19 ` Tom Tromey
2022-06-02 16:07 ` Eli Zaretskii
2022-06-02 19:29 ` Jon Turney
2022-06-03 5:28 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkwnoeuw.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).