From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Bernd Edlinger <bernd.edlinger@hotmail.de>
Subject: Re: [PATCH] gdb/testsuite: Fix libc_has_debug_info when there's no libc
Date: Mon, 29 Apr 2024 23:07:36 -0300 [thread overview]
Message-ID: <87cyq7zjpz.fsf@linaro.org> (raw)
In-Reply-To: <87wmokf5bt.fsf@tromey.com> (Tom Tromey's message of "Fri, 26 Apr 2024 10:37:26 -0600")
Hello Tom,
Tom Tromey <tom@tromey.com> writes:
>>>>>> "Thiago" == Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:
>
> Thiago> Fix by:
>
> Thiago> - always defining libc_has_debug_info and message with a default
> Thiago> value,
> Thiago> - adding a pattern for the case where there's no libc.so in the
> Thiago> inferior, and
> Thiago> - removing the default pattern, which doesn't serve a purpose anymore.
>
> Thiago> Also, remove a couple of verbose messages which aren't really useful
> Thiago> because they're redundant with the $message variable.
>
> Thanks. This looks reasonable to me.
> Approved-By: Tom Tromey <tom@tromey.com>
Thank you.
And thank you Bernd for testing the patch.
Though Pedro raised concerns about libc_has_debug_info:
https://inbox.sourceware.org/gdb-patches/b0409c48-7f9c-4430-91d9-dc7cfa86a9c7@palves.net/
So I just sent a new patch which is an alternative to this one:
https://inbox.sourceware.org/gdb-patches/20240430015325.89780-1-thiago.bauermann@linaro.org/
which restores the original behaviour and also fixes Bernd's reported
Tcl error.
--
Thiago
prev parent reply other threads:[~2024-04-30 2:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 2:52 Thiago Jung Bauermann
2024-04-26 5:09 ` Bernd Edlinger
2024-04-26 16:37 ` Tom Tromey
2024-04-30 2:07 ` Thiago Jung Bauermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyq7zjpz.fsf@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=bernd.edlinger@hotmail.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).