From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH v2 1/4] gdb: make target debug functions return std::string
Date: Fri, 19 Apr 2024 14:22:28 -0600 [thread overview]
Message-ID: <87cyqlt857.fsf@tromey.com> (raw)
In-Reply-To: <20240419194732.2276504-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Fri, 19 Apr 2024 15:46:51 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> From: Simon Marchi <simon.marchi@efficios.com>
Simon> Change the functions in target-debug.h to return string representations
Simon> in an std::string, such that they don't need to know how the printing
Simon> part is done. This also helps the following patch that makes the debug
Simon> prints in debug_target one-liners.
Simon> Update target-delegates.c (through make-target-delegates.py) to do the
Simon> printing.
Simon> Add an overload of gdb_puts to avoid using `.c_str ()`.
Thanks for the update.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-04-19 20:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 19:46 Simon Marchi
2024-04-19 19:46 ` [PATCH v2 2/4] gdb: make debug_target use one-liners Simon Marchi
2024-04-19 19:46 ` [PATCH v2 3/4] gdb: make regcache::debug_print_register return a string Simon Marchi
2024-04-19 20:23 ` Tom Tromey
2024-04-19 19:46 ` [PATCH v2 4/4] gdb: add target_debug_printf and target_debug_printf_nofunc Simon Marchi
2024-04-19 20:22 ` Tom Tromey [this message]
2024-04-19 20:30 ` [PATCH v2 1/4] gdb: make target debug functions return std::string Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyqlt857.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).