public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/4] gdb: make target debug functions return std::string
Date: Fri, 19 Apr 2024 16:30:57 -0400	[thread overview]
Message-ID: <dbf85457-9f3f-4099-ad58-8b7021010f07@efficios.com> (raw)
In-Reply-To: <87cyqlt857.fsf@tromey.com>

On 2024-04-19 16:22, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> From: Simon Marchi <simon.marchi@efficios.com>
> Simon> Change the functions in target-debug.h to return string representations
> Simon> in an std::string, such that they don't need to know how the printing
> Simon> part is done.  This also helps the following patch that makes the debug
> Simon> prints in debug_target one-liners.
> 
> Simon> Update target-delegates.c (through make-target-delegates.py) to do the
> Simon> printing.
> 
> Simon> Add an overload of gdb_puts to avoid using `.c_str ()`.
> 
> Thanks for the update.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, I pushed the series.

Simon

      reply	other threads:[~2024-04-19 20:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 19:46 Simon Marchi
2024-04-19 19:46 ` [PATCH v2 2/4] gdb: make debug_target use one-liners Simon Marchi
2024-04-19 19:46 ` [PATCH v2 3/4] gdb: make regcache::debug_print_register return a string Simon Marchi
2024-04-19 20:23   ` Tom Tromey
2024-04-19 19:46 ` [PATCH v2 4/4] gdb: add target_debug_printf and target_debug_printf_nofunc Simon Marchi
2024-04-19 20:22 ` [PATCH v2 1/4] gdb: make target debug functions return std::string Tom Tromey
2024-04-19 20:30   ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbf85457-9f3f-4099-ad58-8b7021010f07@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).